fix(amazonq): Render first response before receiving all paginated inline completion results #7663
+80
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| await vscode.commands.executeCommand('editor.action.inlineSuggest.hide') | ||
| await vscode.commands.executeCommand('editor.action.inlineSuggest.trigger') | ||
| this._refreshedSessions.add(this.activeSession.sessionId) | ||
| } |
Contributor
There was a problem hiding this comment.
@leigaol so this will only be invoked when cx click ">" or "<" correct? So the suggestions in the pagination response will only be rendered once they press either keyboard shortcut right?
Contributor
Author
There was a problem hiding this comment.
Yes. Do not render paginated response if there is no Left Right key input.
Will-ShaoHua
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previous the pagination API call was blocking and it does not render until all pagination API calls are done.
Without a force refresh of the inline ghost text, paginated response will not be rendered.
Solution
Note that we can do such refresh below whenever the pagination session finish but that will result in inline completion flickering, hence it is better to do it on demand when Left or Right is pressed.
feature/xbranches will not be squash-merged at release time.